Using Variables and calling subs

I'm having some trouble getting to grips with using/calling variables and other sub routines. I thought I'd use the following bits of code as an example of what I currently have and with your help how you think it SHOULD read.

Please Login or Register  to view this content.

As you will no doubt guess each Private Sub is attached to a command button, when you click the button it checks to see if the selected cell is within a range and if it is changes it's colour. There are more than 2 buttons in total by the way, I've just using 2 as an example (hence my desire to write tighter code).

The only code difference in the routines is the colour that the cell is changed to, so it would make sense to use variables but I'm falling down at this point as to how to declare them. Also you'll notice the range that the function checks is the same, again a variable for this seems logical called from outside the routine this time?

The way I would expect the whole thing to work is have 1 sub routine written elsewhere that's called when the command button is clicked. The colours would be a variable at the start too. I'm thinking something along the lines of the following (naturally the code is just a concept):

Please Login or Register  to view this content.

If anyone can spare the time to show me how to improve this code I'd be grateful.

Thanks in advance.

Brelin

Thanks for that reply Roy ...I was so close but so far away lol.

I'm particularly interested in the opener:

Option Explicit
Dim intColour

...is this how you declare the variable 'globally' so to speak, so you only need reference the actual value in the individual code later? (e.g. intColour = 1)

Also there is no declaration of the type of variable after 'Dim intColour' either, so does this mean that's it's not always needed?

Thanks again

Brelin

Thanks for all the responces, I'm going to have a look at this at lunch today and apply it throught my spreadsheet.

Thanks again

Brelin

Originally Posted by royUK

The code is called by buttons, each button appears to be setting the colour so it didn't look as if what you are suggesting could happen

Ok, I guess I'm just used to pain-in-the-backside-users going poking in the 'macro' menu