Infinite Loop

**randell.graybill** · 02-10-2010, 11:17 PM

Towards the bottom I highlighted the code that I believe is giving me the problem. I want to ask the user two questions to make sure everything worked correctly. IE the printer was on when the macro was ran would be an example of something not going correctly, because if they click yes to both questions then the original data that the macro modified will be deleted. But if the user clicks yes on both of the questions the code that is supposed to run does, but then it just hangs.

Please Login or Register  to view this content.

**randell.graybill** · 02-11-2010, 09:40 PM

No one has any ideas?

**Mallycat** · 02-11-2010, 10:09 PM

It is really hard to work out what you are doing here, but here is my feedback

Please Login or Register  to view this content.

The line above looks problematic to me for a number of reasons.
Firstly it is an If/Then statement, but you are not giving the user any opportunity to say "it's not OK". So no matter what happens, it is going to pass this test.
Secondly, you have a Goto after the THEN statement. This is not required, nor is the Continue: line marker. It will automatically enter the loop if the test passes.

Then this next line of code looks like a problem too for similar reasons

Please Login or Register  to view this content.

You should structure your If/then statements like this.

Please Login or Register  to view this content.

See if that solves your problem

**randell.graybill** · 02-12-2010, 01:19 AM

Thanks, I will try it tomorrow and let you know if it works!

**JBeaucaire** · 02-12-2010, 01:54 AM

A lot of recorded code, edit out all the stuff it records that you know you don't need...for instance if you add a box around a cell, you only need the 4 lines of code that put the left/right/top/bottom on the cell, all the rest is dross.

Compare this to your original to see how much reduction in your code is possible by removing the dross and merging multiple lines of "selecting" into one line of direct command.

Please Login or Register  to view this content.

**randell.graybill** · 02-12-2010, 10:44 PM

Thanks JB, yeah I'm not very good at writing code, I still have to record most of what I know, I've picked up a few things from the peeps here and will look over what you've done. Thanks for your help.