Search efficiency

I am running a fairly large block of code on quite a lot of data(4 to 5 thousand lines x several columns).

I have two criteria:

"wsApt.Cells(lRow, 2) and wsApt.Cells(lRow, 5).Value" need to match when looking through a sheet with thousands of lines. Upon finding a match, the value of a certain cell(wsReadings.Cells(rReadings.Row, 6)) should be pasted into wsApt.Cells(lRow, 6). This might be a little hard to follow, so I have attached the code.

Please Login or Register  to view this content.

Any input would be greatly appreciated. Sorry if I am not clear enough, I'll try to help you understand. Thanks in advance.

Bump no response.

You haven't said what the problem is, or what happens when you step through the code.

So sorry about that.Maybe I should go down in history as one of the most bothersome users of this forum(which is really super), but I hope not. I got way too busy in the office here doing about five things at once and forgot to ask the question.

My question is, how can I do this more efficiently? Also, searching simultaneously for both criteria is not working in the code I have shown. I only get any result when I comment one of the criteria out, which doesn't really solve my problem.

We like to have the whole picture wherever possible. We can help suggest corrections to existing code if it's basic and clear in the query, yours really isn't.

For your situation, it would simpler for us if you simply upload a sample workbook showing the data and mockup of your desired results. Your existing code in the workbook is a plus, but if you show us quickly what you have for data and what you want for criteria selection and results, we can offer more exacting suggestions.

Click GO ADVANCED and use the paperclip icon to upload a desensitized copy of your workbook.

One minute and I'll get it for you.

Here is the data which I am using. The code is not included, due to the file size limit on uploads to your forum. If you want, I can email you a copy with the code in it.

Water Meter Billing, Groves tab, is where you find the meter numbers that will, along with the meter reading date. This is what is searched for on the Readings tab(there are actually 4,000 lines on this sheet). The number in column 6 is what should be pasted as the begin read for the line of readings on the begin date, and same for the end readings.

Let me know if I need to clarify any further.

Hi,

It's still not entirely clear. It's always best if you can show typical examples of the results you expect with a short narrative as to the rules you've applied and the cells/sheets involved in arriving at the results.
And since your basic question is about your code we really do need to see that in the context of the workbook. The file example is very small and there's no reason why the addition of the code modules should stop it uploading.

Upload the file including macros and the details above and no doubt we can then help.

Rgds