Combining object (textbox and combobox) change events

Hi,

I have a userform with seven textboxes and seven related comboxes. So far the code works by preventing the combobox from being activated unless something is in the related textbox. Also it prevents the OK button from being activated if a textbox is populated but its related combobox is empty:

Please Login or Register  to view this content.

To be more efficient because the code is redundant, I have create two generic subs (one for textboxes and one for comboboxes) and I call each respective sub from the Change Event sub for the respective textbox and combobox.

Is there a way to remove all these change event subs. Something maybe like:

Please Login or Register  to view this content.

I know that this is not correct, but there is a correct syntax or this not possible?

abousetta

Do not use 'Call' (it's 2011 !!)

Please Login or Register  to view this content.

It's always practical to give macro's that can be 'called' a discriminative name.
I use a capital, followed by an underscore.

The common way to make common event code for different controls is to use a custom class. Since each of your textboxes is paired with a combo box, this custom class is for that pair.

Insert a Class module, change its name to clsPairedControls and put this code into it.

Please Login or Register  to view this content.

Then one has to create instances of that class and assign the appropriate controls to the class and store them in the userform.
Put this code in the userform's code module.

Please Login or Register  to view this content.

I've assumed that the default (initial) Enabled for the comboboxes is False and the default Enabled for the command button is also False.

Thanks Mike. I am struggling to get your approach to work. I have stripped the form down to the bare essentials (attached). Its giving me an error at this line of code as object support this property or method:

Please Login or Register  to view this content.

abousetta

Thanks snb. I'm still self-teaching myself programming and so I may not be up to 'code'. I just learned to 'call' other subs and that's how I have been using it. I will keep this in mind for better coding practices.

abousetta

Also a class approach, but maybe simpler, using an array.

Ahh... the controls are all in a frame.
The code was using ComboCtrl.Parent to refer to the Userform. Since they are in a frame, that returns the frame not the userform.
So that needs to be changed to ComboCtrl.Parent.Parent

Please Login or Register  to view this content.

Thanks snb and mikerickson. I have learned alot from this thread.

abousetta