Trouble defining variables in simple macro - newbie

Originally Posted by abousetta

Hello,

Please add code tags around your code. They are the # mark in the advanced reply. That makes the code easier to read.

What your problem is not in the code, it's that you didn't declare what the variables mean.

These two different approaches will give you the same result:

Please Login or Register  to view this content.

Or

Please Login or Register  to view this content.

When you use Option Explicit then you have to define every variable type or you will get this error. It is good coding practice to keep this statement as it saves memory and forces you to correctly declare variables. Also it will help catch a lot of stupid typos that you won't be able to catch easily.

Good luck.

Thanks. I think I will try to keep the explicit option on. My problem is that VBA for dummies gives me code with that option turned off so I have tyo figure out what is not defined and fix it. Not easy for a newbie. :D

If you don't mind, can you tell me what this does / means? I'm not familiar with the DIM command and not sure how that will make my code work in explicit mode. Thanks! I like to understand things rather than just sticking them in. It's how I learn.

Please Login or Register  to view this content.

Originally Posted by Winon

Try:

Please Login or Register  to view this content.

Thanks! That way seems more compressed and efficient than what I had. I shall try all of these when I get home.

Originally Posted by royUK

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code. Posting code without them makes your code hard to read and difficult to be copied for testing. Highlight your code and click the # at the top of your post window. For more information about these and other tags, found here

Your post does not comply with Rule 1 of our Forum RULES. Your post title should accurately and concisely describe your problem, not your anticipated solution. Use terms appropriate to a Google search. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will be addressed according to the OP's experience in the forum: If you have less than 10 posts, expect (and respond to) a request to change your thread title. If you have 10 or more posts, expect your post to be locked, so you can start a new thread with an appropriate title.
To change a Title on your post, click EDIT then Go Advanced and change your title, if 2 days have passed ask a moderator to do it for you.

My apologies, I believe I fixed everything now. If not please let me know. Thanks everyone. I appreciate it very much. I'm new but determined. So please forgive my simple (and maybe stupid) questions. :D

It's in a workbook called cell_values.xlsm. I am getting a "not defined" error but it highlights different parts of my macro when the error comes up depending on how I fiddle with the sheet and workbook descriptions.

The Contents part I'm literally taking from the book but the darn thing doesn't work. Code I completely copy from the book doesn't work either, probably because I have Explicit turned on. Here's an example straight from the book that I can't get to work no matter what I do:

Please Login or Register  to view this content.

So I'm trying to learn what to do to modify it to work in that mode.

Not sure what you mean regarding declaration but it was supposed to tell me the value of a cell. Sorry, I'm kinda lost in the woods here. When the textbook examples spur errors I have no idea where to go from there. LOL

The problem is the last few macros I tried gives me the same undefinied errors, so I have to be doing something wrong in my programming syntax somewhere.

Originally Posted by Winon

Hi poetstorm,



The (“Sheet1”) and (“A1”) are not Quotation marks recognised by VBA. You should change it form “Sheet1” to ("Sheet1") and ("A1")and then copy and use the code below:

Also note the correct Quotation marks.

Please Login or Register  to view this content.

Hope it helps

Well what do you know, it was mainly a simple matter of quotes. Go figure. (Would have been nice of the book's author to tell me I neded that "Dim" line in there too.)

Thanks so much for the help, both of you. I have been pulling my hair out and ready to give up on teaching myself VBA. Thanks again! (I may need to find myself a new book too LOL)

@ abousetta,

Thanks abousetta. I was just lucky to spot the "mistake". What you gave him was more than perfect and at first I could also not understand why he would have a problem with it.