+ Reply to Thread
Results 1 to 14 of 14

Macro or VBA code to open many files, copy text, close file, paste text in second workbook

  1. #1
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Macro or VBA code to open many files, copy text, close file, paste text in second workbook

    I have many excel file that I need to open and copy one number, 12 names and 12 dates. Then paste this text into a second wookbook. I have a lot of files and hope their is a way to automatically open each file and auto populate to second workbook, close file and open the next.

    Sorry my first post, hope I'm giving enough info.
    Any help would be greatly appreciated

  2. #2
    Forum Contributor
    Join Date
    06-18-2010
    Location
    USA
    MS-Off Ver
    Excel 2016
    Posts
    541

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    In the 2nd workbook, let's call it "Master" for examples sake...where does the data that is being copied need to be pasted? Also in the workbooks that are being copied from, is it always the same range that is being copied or does it vary?

  3. #3
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Something like this?


    http://www.excelforum.com/excel-prog...workbooks.html

  4. #4
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    The second workbook or master the info is being pasted across columns, the number under A column a name under B, date under C and keeps going with 11 more names and dates. Then down to next line with the next workbook and so on. The info being copied from the workbooks is always in the same range.

  5. #5
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Did you try the example in post #3?


    Please Login or Register  to view this content.

  6. #6
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    I did try your post 3 and it worked up to opening the first file but then had an issue (something I changed). Below is what I changed your code to and it had an issue with the second line under "With sourceData. It opened the first file and cell


    Sub Cons_data()

    Dim Master As Workbook
    Dim sourceBook As Workbook
    Dim sourceData As Worksheet
    Dim CurrentFileName As String
    Dim myPath As String
    Application.ScreenUpdating = False
    'the files contain data to be compiled
    myPath = "C:\Documents and Settings\jnm0128\My Documents\TEST PCN's"

    CurrentFileName = Dir(myPath & "\*12345.xlsx")

    'Create a workbook for the pcn report
    Set Master = ThisWorkbook

    Do
    Workbooks.Open (myPath & "\" & CurrentFileName)
    Set sourceBook = Workbooks(CurrentFileName)
    Set sourceData = sourceBook.Worksheets(1)

    With sourceData
    .Range("EM1").Copy
    Master.Worksheets(1).Range("A3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("J7").Copy
    Master.Worksheets(1).Range("B3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("J8").Copy
    Master.Worksheets(1).Range("C3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("V7").Copy
    Master.Worksheets(1).Range("D3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("V8").Copy
    Master.Worksheets(1).Range("E3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("AH7").Copy
    Master.Worksheets(1).Range("F3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("AH8").Copy
    Master.Worksheets(1).Range("G3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("AT7").Copy
    Master.Worksheets(1).Range("H3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("AT8").Copy
    Master.Worksheets(1).Range("I3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("BF7").Copy
    Master.Worksheets(1).Range("J3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("BF8").Copy
    Master.Worksheets(1).Range("K3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("BR7").Copy
    Master.Worksheets(1).Range("L3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("BR8").Copy
    Master.Worksheets(1).Range("M3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("CD7").Copy
    Master.Worksheets(1).Range("N3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("CD8").Copy
    Master.Worksheets(1).Range("O" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("CP7").Copy
    Master.Worksheets(1).Range("P" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("CP8").Copy
    Master.Worksheets(1).Range("Q" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DB7").Copy
    Master.Worksheets(1).Range("R" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DB8").Copy
    Master.Worksheets(1).Range("S" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DN7").Copy
    Master.Worksheets(1).Range("T" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DN8").Copy
    Master.Worksheets(1).Range("U" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DZ7").Copy
    Master.Worksheets(1).Range("V" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("DZ8").Copy
    Master.Worksheets(1).Range("W" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("EL7").Copy
    Master.Worksheets(1).Range("X" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    .Range("EL8").Copy
    Master.Worksheets(1).Range("Y" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues)
    End With

    sourceBook.Close

    CurrentFileName = Dir()
    Loop While CurrentFileName <> ""
    Application.ScreenUpdating = True
    End Sub

  7. #7
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    You have to qualify where to paste to.

    There must be an easier and better way but in the meantime try this


    Please Login or Register  to view this content.

  8. #8
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Same thing happens, when it get to this line in the code it has an error. .Range("A3" & Rows.Count).End(xlUp).Offset(1, 0).PasteSpecial (xlPasteValues).

    When I run it I get a (Run-time error '1004' Application-defined or object-defined error) when i select the "Debug" button it opens the file I'm trying to copy the data from and also highlights to line above.

    Other than adding the folder destination under mypath in your code, is there anything else in the code I should be changing before trying it?

  9. #9
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    jolivanes,
    Would it help if I attached the two files in question? If so how can I attach them so you can take a look. I do not see any tool to allow me to attach files.

  10. #10
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Click on the Go Advanced button and Manage Attachments. Upload the files in question and attach.
    Good luck

    John

  11. #11
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    John,

    I attched one copy of the file I'm trying to take info from (see PCN Form.xlsx in yellow) with the 1 PCN number up in the top right I'm trying to copy to master sheet A3, then there are 12 places (in Yellow) that individuals need to add thier name and 12 places to add date. Note: these names and dates are in merged cells. There are many of these files and the file names all start with a # like (28035PCN.xls).

    The "Master Date Data" file is where I'm trying to copy the info to. The PCN Number to A3, Intiator signature and date to B3 and C3 and Engineer signature and date to D3 and E3 and so on.

    Then close file and open next.

    Thanks so much for your help.
    Attached Files Attached Files

  12. #12
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Bikeman
    Try this and see what happens.

    I think you should re-design, if possible, your workbooks because merged cells can be a problem to work with in code.


    Please Login or Register  to view this content.

  13. #13
    Registered User
    Join Date
    11-27-2012
    Location
    Portland, Oregon
    MS-Off Ver
    Excel 2007
    Posts
    81

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    John,
    Thanks this did work! It has a couple of issues but I think you are right, I need to re-design the workbooks like you suggested. I had the feeling the merged cells were going to be an issue.

    I will work on new workbooks before going any further.

    Thanks again for you help.

  14. #14
    Forum Expert
    Join Date
    10-06-2008
    Location
    Canada
    MS-Off Ver
    2007 / 2013
    Posts
    4,777

    Re: Macro or VBA code to open many files, copy text, close file, paste text in second work

    Serious issues or manageable issues?

    Like I said previously, there must be code that is shorter/better and I was hoping someone with that kind of skill would jump in but for now it works you said.

    Good luck.

    John

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1