Form nightmare - project resets = global variables lost

And this was all working so well up to now

I am working on a project which requires extensive user input by forms. I've recently broken the code and I can't work out why (I have backups but I don't want to lose my recent changes).

Any one have any ideas to help solve this mystery?


One of the main forms in the project is called frmMenu2. It is explicitly declared in a calling sub and shown modeless. Calling sub code below:

Please Login or Register  to view this content.

One of the events on frm_Menu2 is cmdEdit_Click. It's code looks something like this:

Please Login or Register  to view this content.

Load_frm_Edit shows a modal form (explicitly declared as new instance) to allow the user to input edits.
Depending on the users input, this sub then unloads frm_Edit and then either 1. loads Menu2 (by calling Load_frm_Menu2 again) or 2. wipes all variables and loads Menu1.

However something has gone wrong. After a successful entry, Menu2 is loaded and but I then receive a project reset message (and lose all global variables - thus breaking the project).

I have stepped through the code and the problem is occurring on the

Please Login or Register  to view this content.

line of sub cmdEdit_Click. But that instance of Menu2 should be unloaded and gone, no? And assuming that the original Menu2 form is still in memory, why would it crash here?

Any ideas?

I need help. So to make it easier for anybody offering to debug this, I have created a dummy workbook which replicates the issue. Step through after the code reaches the

Please Login or Register  to view this content.

to see what I mean.

Hello mc84excel,

That is some crazy code. This code should be scrapped and redone.

I am not sure what you are trying to achieve but I can tell you this is not the way to do it.

Originally Posted by Leith Ross

Hello mc84excel,

That is some crazy code. This code should be scrapped and redone.

I am not sure what you are trying to achieve but I can tell you this is not the way to do it.

I agree that the code needs improving but I'm not so sure about scrap & redo. I don't suppose you could provide specifics as to what you consider "crazy" about it?

Please take into account that the code I've provided in this thread is only a "dumbed-down" portion of only a small fraction of the overall project code. So of course it will look unusual since it's taken out of context and missing all practical functionality and form features/design.'

I can't provide the entire code unfortunately so if you wish to help, please use the mock-up I uploaded - this is sufficient to recreate the issue I'm experiencing.

Originally Posted by kierstin

Well I'm no expert but it looks as though you might have some syntax errors in your DoWhile Statement.

Hi kierstin. I'm no expert either so I appreciate any suggestions to what is causing this.

Originally Posted by kierstin

Shouldn't ".Show vbModal" be vbModal.Show? (Object.Method)

Please Login or Register  to view this content.

has the options of

Please Login or Register  to view this content.

or

Please Login or Register  to view this content.

Leaving the attribute blank causes it to default to vbModal. I removed it anyway to see if it helped but I still receive the project reset.

Originally Posted by kierstin

And there is a dot separator on the next line that doesn't separate anything.

You mean the

Please Login or Register  to view this content.

? That's a property of the edit form.


UPDATE
kierstin - I think you are onto something with the Do While Loop. I commented this out (see below) and ran the test. And the project wasn't reset!

Please Login or Register  to view this content.

+1 for kierstin for giving me the clue to solving this.

The Do While loop to handle the edit form button response was causing the project reset on Menu2.

I recently implemented this Loop as part of my goal of moving towards better coding practices (In this case: Avoiding all use of GoTo except on labels for error handling and exit procedures).

Below is my fix to the mockup code. By reverting to using GoTo again.
(Sorry GoTo haters. This was the only way to avoid this issue. I'll rep you if you can prove me wrong using the mock-up provided...)

Please Login or Register  to view this content.

Please Login or Register  to view this content.

+1 to shg

If you know why the Do Loop worked but the Do While triggered a project reset, I'd be interested to learn.


P.S. re the 2x Resume. It's something I stumbled across while studying up on error handling.

'Note that second Resume. This is a trick I learned recently:
'It will never execute in normal processing, since the Resume <label> statement will send the execution elsewhere.
'It can be a boon for debugging, though.
'When you get an error notification, choose Debug (or press Ctl-Break, then choose Debug when you get the "Execution was interrupted" message).
'The next (highlighted) statement will be either the MsgBox or the following statement.
'Use "Set Next Statement" (Ctl-F9) to highlight the bare Resume, then press F8.
'This will show you exactly where the error was thrown.

(The mockup code is lacking a debug.assert false or msgbox as a line before the first resume - which this trick needs for it to work).

I recently had this problem again on another form. I googled and found a way to work round it

HTML Code: 

Using Me.Hide wasn't a drawback for me as the form I wanted to return to didn't need anything reset in between switching forms.

No idea why the Unload Me sometimes triggers project resets.