XML VBA Error Catching

This code gets the data from the website

http://api.yr.no/weatherapi/location...5;lon=8.555967

The information obtained from this website is then organized in a spreadsheet. I am trying to avoid crashing the program. I've noticed that if an incorrect latitude/longitude is input then the website returns an error. What would need to be added in these codes to have the code check if an error is produced and then ask the user to check their input BEFORE adding the input into the "Site List" worksheet.

Please Login or Register  to view this content.

Please Login or Register  to view this content.

If you want to catch the errors as they happen, i think you will need to collect them differently. It looks like your user is filling in a form, and then all of the fields values collected are validated with a series of IF statements.



Honestly, this would appear to be a case where you could tie those values to specific cells in a worksheet - and just use the worksheet in place of a form. The advantage there is, worksheet cells can be validated to immediately tell someone what is wrong when they enter something.

Using worksheet data validation would eliminate the need for VBA error checking - cells can be validated to only accept numbers. Does that make sense?

You appear to already have code to check for valid input before trying to get the data from the website, is it not working as expected?

Well that is just for making sure that the input data is in the correct format. But if the person inputs a longitude/latitude that does not exist then you would get an error from the API.

So I would guess that the best way for the user to be informed that there is an error is exactly when the person is trying to add/edit a site. That way they will know what is wrong and correct it. I would figure that the way to do that is that in the edit and add tabs the code can send a request to the API and if the API returns an error tell the user that whatever they are trying to add or edit is incorrect, to try again.

What's actually returned by the site when that happens?

When you run the code with invalid latitude and longitude is that what's returned in the responseText of the request?

If it is I would suggest that you check the responseText before you load it into the XLM/DOM document Resp.

Something like this perhaps.

Please Login or Register  to view this content.

When you send out an XML request what's returned is what you would see if you entered the URL manually.

So when you put in a invalid latitude/longitude the code should return the error message in the response text of the XML request.



To pinpoint the sites just refer to the current site you are on in the loop throught the site list

Please Login or Register  to view this content.

Forgot to ask, did you try the code I suggested?