+ Reply to Thread
Results 1 to 4 of 4

Help with Damage Record code (irow)

  1. #1
    Registered User
    Join Date
    09-25-2015
    Location
    England
    MS-Off Ver
    Home & Business 2013
    Posts
    4

    Lightbulb Help with Damage Record code (irow)

    Hi guys,

    I am trying to get the below code to work but cannot for the life of me see why its not working - it just keeps coming back saying it cant find the next number - can you take a look at it for me?

    Sub SaveAsPDF()

    Dim ReturnsLogWorksheet As Worksheet
    Dim ReturnsFormWorksheet As Worksheet
    Dim cells As Range
    Dim iRow, iReturnsRow
    Dim sReturnsNumber As String, sAccountReference As String, sCustomerName As String, sSalesOrder As String, sDateOrdered As String, sItem As String, sQuantity As String, sReason As String, sDescription As String, sValue As String, sCCarrier As String, sCDate As String, sCRef As String, sCEDate As String, sRCarrier As String, sRDate As String, sRRef As String, sREDate As String, sSupCredit As String, sSupRequest As String, sSupCreditDate As String, sCarrierCredit As String, sCarrierRequest As String, sCarrierDate As String

    iReturnsRow = 0

    Set ReturnsLogWorksheet = ThisWorkbook.Worksheets("Returns Log")
    Set ReturnsFormWorksheet = ThisWorkbook.Worksheets("Returns Form")
    ' search for the start of the returns log
    iRow = 1
    While iRow < 100 And ReturnsLogWorksheet.cells(iRow, 1).Value <> "Returns Number"
    iRow = iRow + 1
    Wend

    If iRow >= 100 Then
    MsgBox ("Unable to find start of Returns log")
    Exit Sub
    End If

    While iReturnsRow = 0
    iRow = iRow + 1
    sReturnsNumber = ""
    sAccountReference = ""
    sCustomerName = ""
    sSalesOrder = ""
    sDateOrdered = ""
    sItem = ""
    sQuantity = ""
    sReason = ""
    sDescription = ""
    sValue = ""
    sCarrier = ""
    sCDate = ""
    sCRef = ""
    sCEDate = ""
    sRCarrier = ""
    sRDate = ""
    sRRef = ""
    sREDate = ""
    sSupCredit = ""
    sSupRequest = ""
    sSupCreditDate = ""
    sCarrierCredit = ""
    sCarrierRequest = ""
    sCarrierDate = ""


    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 1).Value) Then sReturnsNumber = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 1).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 2).Value) Then sAccountReference = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 2).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 3).Value) Then sCustomerName = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 3).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 4).Value) Then sSalesOrder = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 4).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 5).Value) Then sDateOrdered = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 5).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 6).Value) Then sItem = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 6).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 7).Value) Then sQuantity = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 7).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 8).Value) Then sReason = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 8).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 9).Value) Then sDescription = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 9).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 10).Value) Then sValue = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 10).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 11).Value) Then sCarrier = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 11).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 12).Value) Then sCDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 12).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 13).Value) Then sCRef = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 13).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 14).Value) Then sCEDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 14).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 15).Value) Then sRCarrier = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 15).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 16).Value) Then sRDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 16).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 17).Value) Then sRRef = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 17).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 18).Value) Then sREDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 18).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 19).Value) Then sSupCredit = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 19).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 20).Value) Then sSupRequest = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 20).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 21).Value) Then sSupCreditDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 21).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 22).Value) Then sCarrierCredit = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 22).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 23).Value) Then sCarrierRequest = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 23).Value))
    If Not IsNull(ReturnsLogWorksheet.cells(iRow, 24).Value) Then sCarrierDate = Trim(CStr(ReturnsLogWorksheet.cells(iRow, 24).Value))


    If sReturnsNumber = "" Then
    MsgBox ("Unable to find next Returns number.")
    Exit Sub
    End If
    If sReturnsNumber = "" And sAccountReference = "" And sCustomerName = "" And sSalesOrder = "" And sDateOrdered = "" And sItem = "" And sQuantity = "" And sReason = "" And sDescription = "" And sValue = "" And sCarrier = "" And sCDate = "" And sCRef = "" And sCEDate = "" And sRCarrier = "" And sRDate = "" And sRRef = "" And sREDate = "" And sSupCredit = "" And sSupRequest = "" And sSupCreditDate = "" And sCarrierCredit = "" And sCarrierRequest = "" And sCarrierDate = "" Then iReturnsRow = iRow
    Wend
    ActiveSheet.Unprotect "admin"
    ReturnsFormWorksheet.cells(26, 4).Value = sReturnsNumber
    ReturnsLogWorksheet.cells(iRow, 2).Value = ReturnsFormWorksheet.cells(2, 9).Value
    ReturnsLogWorksheet.cells(iRow, 3).Value = ReturnsFormWorksheet.cells(3, 9).Value
    ReturnsLogWorksheet.cells(iRow, 4).Value = ReturnsFormWorksheet.cells(4, 9).Value
    ReturnsLogWorksheet.cells(iRow, 5).Value = ReturnsFormWorksheet.cells(5, 9).Value
    ReturnsLogWorksheet.cells(iRow, 6).Value = ReturnsFormWorksheet.cells(6, 9).Value
    ReturnsLogWorksheet.cells(iRow, 7).Value = ReturnsFormWorksheet.cells(7, 9).Value
    ReturnsLogWorksheet.cells(iRow, 8).Value = ReturnsFormWorksheet.cells(8, 9).Value
    ReturnsLogWorksheet.cells(iRow, 9).Value = ReturnsFormWorksheet.cells(9, 9).Value
    ReturnsLogWorksheet.cells(iRow, 10).Value = ReturnsFormWorksheet.cells(10, 9).Value
    ReturnsLogWorksheet.cells(iRow, 11).Value = ReturnsFormWorksheet.cells(12, 9).Value
    ReturnsLogWorksheet.cells(iRow, 12).Value = ReturnsFormWorksheet.cells(13, 9).Value
    ReturnsLogWorksheet.cells(iRow, 13).Value = ReturnsFormWorksheet.cells(14, 9).Value
    ReturnsLogWorksheet.cells(iRow, 14).Value = ReturnsFormWorksheet.cells(15, 9).Value
    ReturnsLogWorksheet.cells(iRow, 15).Value = ReturnsFormWorksheet.cells(17, 9).Value
    ReturnsLogWorksheet.cells(iRow, 16).Value = ReturnsFormWorksheet.cells(18, 9).Value
    ReturnsLogWorksheet.cells(iRow, 17).Value = ReturnsFormWorksheet.cells(19, 9).Value
    ReturnsLogWorksheet.cells(iRow, 18).Value = ReturnsFormWorksheet.cells(20, 9).Value
    ReturnsLogWorksheet.cells(iRow, 19).Value = ReturnsFormWorksheet.cells(22, 9).Value
    ReturnsLogWorksheet.cells(iRow, 20).Value = ReturnsFormWorksheet.cells(23, 9).Value
    ReturnsLogWorksheet.cells(iRow, 21).Value = ReturnsFormWorksheet.cells(24, 9).Value
    ReturnsLogWorksheet.cells(iRow, 22).Value = ReturnsFormWorksheet.cells(26, 9).Value
    ReturnsLogWorksheet.cells(iRow, 23).Value = ReturnsFormWorksheet.cells(27, 9).Value
    ReturnsLogWorksheet.cells(iRow, 24).Value = ReturnsFormWorksheet.cells(28, 9).Value

    Dim fName As String
    With ReturnsFormWorksheet ' ActiveSheet
    fName = .Range("D26").Value
    Sheets(Array("Returns Form")).Select
    ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
    GetDesktop() & "\" & fName, Quality:=xlQualityStandard, _
    IncludeDocProperties:=True, IgnorePrintAreas:=False, OpenAfterPublish:=True
    Sheets("Returns Form").Select
    ActiveSheet.Protect Password:="admin"
    End With
    End Sub
    Attached Files Attached Files

  2. #2
    Forum Guru xlnitwit's Avatar
    Join Date
    06-27-2016
    Location
    London
    MS-Off Ver
    Windows: 2010; Mac: 16.13 (O365)
    Posts
    7,085

    Re: Help with Damage Record code (irow)

    Hi,

    Please use code tags when posting code.

    You never assign a value to iReturnRow so this line is always true
    Please Login or Register  to view this content.
    and you therefore go past the end of your data
    Don
    Please remember to mark your thread 'Solved' when appropriate.

  3. #3
    Registered User
    Join Date
    09-25-2015
    Location
    England
    MS-Off Ver
    Home & Business 2013
    Posts
    4

    Re: Help with Damage Record code (irow)

    Sorry about the code tags, I am fairly new to all this.

    See I have used very similar code to this on another project and it works fine so just cant get my head around why it works on that one and not on this.

    Can you point me in the direction for how to put it right? Sorry but I had a bit of help with the original code so cant work out how to correct it.

    I have attached the original coding for you to see how it used to work!

    Thanks,

    Luke
    Attached Files Attached Files

  4. #4
    Forum Guru xlnitwit's Avatar
    Join Date
    06-27-2016
    Location
    London
    MS-Off Ver
    Windows: 2010; Mac: 16.13 (O365)
    Posts
    7,085

    Re: Help with Damage Record code (irow)

    Your If line should read
    Please Login or Register  to view this content.
    note the red part and that the sReturnNumber = "" part at the start has been removed.

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. [SOLVED] Make IRow = 1000 dynamic
    By markDuffy in forum Excel Programming / VBA / Macros
    Replies: 3
    Last Post: 08-11-2017, 12:03 PM
  2. Creating IF statement for iRow Entry
    By excelenergy in forum Excel General
    Replies: 8
    Last Post: 09-29-2014, 04:26 PM
  3. Combinations and iRow formula
    By Fitz1567 in forum Excel Programming / VBA / Macros
    Replies: 0
    Last Post: 11-05-2013, 12:13 AM
  4. [SOLVED] Issue using iRow
    By faoltaem in forum Excel Programming / VBA / Macros
    Replies: 5
    Last Post: 11-15-2012, 03:00 AM
  5. Extensive damage error in excel
    By p00rn00b in forum Excel General
    Replies: 1
    Last Post: 06-17-2009, 06:07 PM
  6. Arranging data:Dim iRow As Long
    By vijaya in forum Excel Programming / VBA / Macros
    Replies: 3
    Last Post: 11-07-2005, 12:45 PM
  7. Error: Damage to the file was so extensive...
    By nvitucci in forum Excel General
    Replies: 0
    Last Post: 09-12-2005, 05:08 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1